This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
fix: ensure to extend function schema only if method available #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently working on a project that is using a version of serverless affected by this. Is there anything i can do to help this PR? |
bharadwajpoduri
approved these changes
Sep 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #173
In order to not break the plugin for
serverlessin version lower than2.10.0wheredefineFunctionPropertieswas added (https://github.com/serverless/serverless/blob/master/CHANGELOG.md#2100-2020-11-03), we should check for it's existence before extending the schemaHow did you implement it:
Checking for the existence of
defineFunctionPropertiesbefore calling itHow can we verify it:
If you try to use plugin with
serverlessin version<2.10.0, it will fail as described in the linked issue. With this change, it will no longer fail.Todos: