Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CSS-235 Change to tsup #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SilverSting
Copy link

  • Replaced react-scripts with tsup
  • Removed babel and its plugins
  • Removed unnecessary assets

- Replaced react-scripts with tsup
- Removed babel and its plugins
- Removed unnecessary assets
@SilverSting SilverSting self-assigned this Oct 17, 2023
@SilverSting
Copy link
Author

Couple of things to notice.

Since the parent repo is public, this repo also has to stay open for visibility. This prevents access to the shared Action Runners. Similar to oprah settings, this has been updated to use runners provided by Github.

@SilverSting
Copy link
Author

SilverSting commented Oct 17, 2023

Hey @mikmorley @jeff-wassouf

FYI, here is a brand new repo that hosts a public (not by choice) package. This was forked from an open source project that was created by an ex ACG employee.

The original repo hasn't been updated for 4 years. But we are still using it in 5 FE apps, including the primary ones like Learn and Teams. In order to gain more control over it, @timkinnane and I have decided to fork this.

@timkinnane
Copy link

It's not necessary to be public just to fork. You can clone as a bare repo then push to a new origin...

https://stackoverflow.com/questions/10065526/github-how-to-make-a-fork-of-public-repository-private

The later steps illustrate how to add the original as a secondary origin, to keep up to date, but it's not really necessary when it's no longer maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants