You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After some more testing, it seems that #747 did not fix the thread safety issues with DivineRPG's armor power handler; in fact, the tweak now seems to cause the mod to leak event handlers.
This PR should (hopefully) fix the armor power handling with a better implementation. The event handler in ArmorPowers is no longer dynamically registered on player cap init, and ArmorDescription event handlers being dynamically registered on equipment change (very hacky) now are only registered once per player, on a consistent logical side. Cleanup and syncing is done by ArmorPowerHandler.
Import Addition for ArmorPowerHandler
The file handling universal tweaks now has the ability to bring in 'ArmorPowerHandler', which is a new feature that enhances the way armor power events are managed when a specific game modification is used.
ArmorPowerHandler Event Registration
The system can now recognize and respond to 'ArmorPowerHandler' events. This helps in better management of armor sets when our game mod is running, particularly cleaning up armor sets effectively.
New Class for ArmorPower Management
We've created a new section in our system called 'ArmorPowerHandler' dedicated to overseeing armor powers and dealing with player armor-related scenarios. It emphasizes safety and precise power control.
New Interface for Armor Power Unsubscription
A new tool has been integrated to easily access the unsubscription method related to armor powers. This allows for specialized handling of armor power unsubscription, where unsubscribed powers will not receive updates nor trigger events.
Improved Armor Powers Consistency
We've upgraded our system to refuse the registration of armor power events that should not happen. This brings about enhanced stability and predictability in our system.
Scheduled Handling of Armor Status Messages
We have a new system mechanism to schedule changes in dealing with armor status messages. This ensures system actions related to armor status messages are always carried out safely and accurately.
Player Event Optimization
Our system can now better manage player events by ensuring they are processed correctly based on unique ID identifiers. This helps to avoid repetitive or unnecessary actions.
Client-side Duplicate Event Cancellation
For players using our integrated servers, there's now a feature that cancels event registrations that are duplicates, based on the player's world information. This helps in better management of resources and enhancing gameplay experience.
Updated Configuration for Armor Handling
We have updated our system's configuration to incorporate the additional features and improvements to the armor power management system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some more testing, it seems that #747 did not fix the thread safety issues with DivineRPG's armor power handler; in fact, the tweak now seems to cause the mod to leak event handlers.
This PR should (hopefully) fix the armor power handling with a better implementation. The event handler in
ArmorPowersis no longer dynamically registered on player cap init, andArmorDescriptionevent handlers being dynamically registered on equipment change (very hacky) now are only registered once per player, on a consistent logical side. Cleanup and syncing is done byArmorPowerHandler.