Skip to content

Rewrite DivineRPG armor set cleanup tweak#804

Merged
ACGaming merged 1 commit intoACGaming:mainfrom
jchung01:mod-tweaks
Feb 22, 2026
Merged

Rewrite DivineRPG armor set cleanup tweak#804
ACGaming merged 1 commit intoACGaming:mainfrom
jchung01:mod-tweaks

Conversation

@jchung01
Copy link
Copy Markdown
Contributor

After some more testing, it seems that #747 did not fix the thread safety issues with DivineRPG's armor power handler; in fact, the tweak now seems to cause the mod to leak event handlers.
This PR should (hopefully) fix the armor power handling with a better implementation. The event handler in ArmorPowers is no longer dynamically registered on player cap init, and ArmorDescription event handlers being dynamically registered on equipment change (very hacky) now are only registered once per player, on a consistent logical side. Cleanup and syncing is done by ArmorPowerHandler.

- Hopefully the thread safety issues are actually gone this time
@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Feb 20, 2026

PR Summary

  • Import Addition for ArmorPowerHandler
    The file handling universal tweaks now has the ability to bring in 'ArmorPowerHandler', which is a new feature that enhances the way armor power events are managed when a specific game modification is used.

  • ArmorPowerHandler Event Registration
    The system can now recognize and respond to 'ArmorPowerHandler' events. This helps in better management of armor sets when our game mod is running, particularly cleaning up armor sets effectively.

  • New Class for ArmorPower Management
    We've created a new section in our system called 'ArmorPowerHandler' dedicated to overseeing armor powers and dealing with player armor-related scenarios. It emphasizes safety and precise power control.

  • New Interface for Armor Power Unsubscription
    A new tool has been integrated to easily access the unsubscription method related to armor powers. This allows for specialized handling of armor power unsubscription, where unsubscribed powers will not receive updates nor trigger events.

  • Improved Armor Powers Consistency
    We've upgraded our system to refuse the registration of armor power events that should not happen. This brings about enhanced stability and predictability in our system.

  • Scheduled Handling of Armor Status Messages
    We have a new system mechanism to schedule changes in dealing with armor status messages. This ensures system actions related to armor status messages are always carried out safely and accurately.

  • Player Event Optimization
    Our system can now better manage player events by ensuring they are processed correctly based on unique ID identifiers. This helps to avoid repetitive or unnecessary actions.

  • Client-side Duplicate Event Cancellation
    For players using our integrated servers, there's now a feature that cancels event registrations that are duplicates, based on the player's world information. This helps in better management of resources and enhancing gameplay experience.

  • Updated Configuration for Armor Handling
    We have updated our system's configuration to incorporate the additional features and improvements to the armor power management system.

@ACGaming ACGaming merged commit 832b986 into ACGaming:main Feb 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants