Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved selection of configs for multihead pretrained head #570

Open
wants to merge 2 commits into
base: multihead-merge
Choose a base branch
from
Open

improved selection of configs for multihead pretrained head #570

wants to merge 2 commits into from

Conversation

bernstei
Copy link
Collaborator

Refactor code that selects configs for pretrained multihead.

  • Strategy by element (new names and one new strategy): exact, subset, superset, any_overlap
  • If strategy picks too many, subselect by composition match (slightly complex algorithm)
  • If strategy picks too few, pick more by random or FPS

@bernstei bernstei changed the base branch from main to multihead-merge August 26, 2024 20:37
@bernstei
Copy link
Collaborator Author

Looks like maybe this changes the selection in some way that leads to different results for some unit test?

@bernstei
Copy link
Collaborator Author

bernstei commented Sep 4, 2024

@ilyes319 any thoughts on this version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bernstei