Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First prototype for Lux potential #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

CheukHinHoJerry
Copy link
Collaborator

@cortner
Copy link
Member

cortner commented Oct 30, 2023

The idea was not add this as an example to the new repo but rather as a prototype for a new potential. We need to reorganise this into a proper package.

@CheukHinHoJerry
Copy link
Collaborator Author

CheukHinHoJerry commented Oct 30, 2023

sorry for misnaming - since the State idea was working gradually on EQM's end we think it is time for us to move all the draft to here and implement it carefully.

I will rename the PR to prevent confusion.

@CheukHinHoJerry CheukHinHoJerry changed the title add example from EQM First prototype for Lux potential Oct 30, 2023
@cortner
Copy link
Member

cortner commented Oct 30, 2023

I'm saying don't even commit as examples. Put it directly into a package structure.

It's not the end of the world just pollutes the git history more than is necessary.

@cortner
Copy link
Member

cortner commented Oct 30, 2023

Secondly - data files should almost never be in a git repo. We have Artifacts for that.

@CheukHinHoJerry
Copy link
Collaborator Author

Sorry about that, I will also be aware in future development. Could you please advise whether we should create a new PR or clean everything up with a single commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants