Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iono computation - addressing #135 #138

Merged
merged 7 commits into from
Jun 8, 2023
Merged

Iono computation - addressing #135 #138

merged 7 commits into from
Jun 8, 2023

Conversation

mgovorcin
Copy link
Contributor

@mgovorcin mgovorcin commented Jun 6, 2023

Changes:

  1. Skip iono_computation if lower/upper band unwrapped interferogram array is empty, i.e. all zeros. Return iono as zeros array
  2. Skip downloading and using water mask if the AOI request is out of SWBD data coverage. TODO: introduce new water masks as mentioned in New Ionosphere Updates do not always complete in Anchorage (Track 131) #135 : EXAMPLES: https://worldcover2021.esa.int/viewer or https://land.copernicus.eu/global/products/wb
  3. fix few typos and add notes in the main regarding the esd and calculation of burst jumps

@mgovorcin mgovorcin requested a review from cmarshak June 7, 2023 16:41
Copy link
Collaborator

@cmarshak cmarshak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Requested some small changes/clarification. Otherwise, let's merge soon so we can test.

isce2_topsapp/__main__.py Show resolved Hide resolved
isce2_topsapp/localize_mask.py Show resolved Hide resolved
isce2_topsapp/localize_mask.py Show resolved Hide resolved
isce2_topsapp/iono_proc.py Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@cmarshak cmarshak merged commit 9ee8b40 into dev Jun 8, 2023
@cmarshak cmarshak deleted the iono branch June 8, 2023 00:58
@dbekaert
Copy link
Collaborator

dbekaert commented Jun 8, 2023

@mgovorcin Should have meta data to the iono correction in gunw to track how it was produced

Water mask source : e.g none, gssh, …
Method: e.g none, framebased, subswath

Then we can always track it in the product. Please add in next pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants