-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Ionosphere Updates do not always complete in Anchorage (Track 131) #135
Comments
The errors could be related to numpy, ISCE2 and the environment (maybe using the latest isce2 w/ python 3.10 would resolve this). |
swapping to latest isce should only be done after verification there is no new issues introduced in the GUNW product. |
@cmarshak @dbekaert I run the failed job locally. It looks like the water mask is the issue, the downloaded file has nodata over the whole scene. SRTM Water Body Data does not have the coverage over that area. Coverage: |
I see; so, Anchorage is too far North at ~61˚ latitude to generate a valid SRTM water mask for the iono correction. I was concerned why the dem staging didn't fail; forgot that SRTM has a slightly smaller area of coverage than the Copernicus DEM we are using. @dbekaert could you provide guidance as to what you would like for such a case for operational use? Should we:
|
We should really know what the coverage is of all of our ancillaries and have this documented on our website. We should capture what ancillaries are required and for which the code should error out in case we go beyond. For example:
We have established that GSSHHS is incorrect at higher latitudes and should be avoided. What are alternatives, and if we pick an alternative we should inspect and assess the quality of the watermask globally prior to its use. What is ASF team using as water mask @jhkennedy ? |
Some guidance to make progress @cmarshak @mgovorcin :
|
Here's the blurb in our INSAR_GAMMA product guide describing the water masking approach for jobs:
|
Additional issues over Chile with the same error:
This is no longer a water mask issue based on coverage. Below is where the frames are: |
For comparison, here are the successful jobs (12/15 succeeded):
|
@cmarshak it appears that issue comes from ionosphere computation swath by swath, where one swath is completely over the water and masked out. The iono fails over that swath IW3. Will try to see how to bypass this. The other issue might occur with merging the swaths afterwards ionSwathBySwath mode is activated due to different Starting Range per Swath between reference and secondary scenes TODO: need to modify compute_ionosphere step to work with nodata arrays. - SOLVED |
@cmarshak @dbekaert ... I am thinking about quality layer for ionosphere, it could be the boolean array of the pixels used in the computation. This could give us an idea of how many pixels and their distribution are used in iono computation (aka constrains to plane fitting involved in filt_ion step). Before proceeding, would like to hear your opinion on this. Would you like to have something like this in GUNW package next to iono layer? |
Interesting to see what you think, how it would be used downstream in ts. Is the coherence of the ifg not a good marker too? A binary layer would be small. |
Describe the bug
I submitted 15 frames over Anchorage AK. 5/15 failed during the iono step. Here is a sample log:
All the failed jobs are here:
The text was updated successfully, but these errors were encountered: