-
Notifications
You must be signed in to change notification settings - Fork 1
Check whether to load databases after sync mode check #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Config:
|
} else { | ||
false | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just do
fn is_matching_resolved_dep(&self, dep: &ResolvedDependency) -> bool {
self.name == dep.name.as_ref() && self.version == dep.version
}
It can also be inlined since it's only used once
src/main.rs
Outdated
dep.from_lockfile = true; | ||
} | ||
}) | ||
.collect::<Vec<_>>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just create a new vec rather than mutating? I also don't think it's going to be super useful for that to be parallel, did you notice a difference?
Closes #205