Skip to content

feat: remove deprecated U flag in read() #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GeorgeVince wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: remove deprecated U flag in read() #29

GeorgeVince wants to merge 1 commit into from
+1 −1

Conversation

@GeorgeVince
Copy link

@GeorgeVince GeorgeVince commented Oct 2, 2025 •
edited
Loading 

test/unit/services/test_companies.py: 34 warnings
  /usr/local/lib/python3.8/site-packages/sqlpy/sqlpy.py:462: DeprecationWarning: 'U' mode is deprecated
    with open(file, 'rU') as queries_file:

What's New In Python 3.4 (The Deprecation Warning):
This release note confirms that the DeprecationWarning was introduced in Python 3.4.

Python 3.4 Release Notes (Check the Deprecated section)

Python 3.11 Deprecation/Removal Notes (The Final Removal):
This documentation confirms that the 'U' mode, after being deprecated for years.

TODO fix tox:
https://github.com/9fin/sqlpy/blob/master/tox.ini#L8

@GeorgeVince GeorgeVince changed the title fix: remove deprecated U flag in read() feat: remove deprecated U flag in read() Oct 2, 2025
Taylor-Mudd-9fin
Taylor-Mudd-9fin approved these changes Oct 14, 2025
View reviewed changes
Copy link

@Taylor-Mudd-9fin Taylor-Mudd-9fin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Deprecated since 3.3, seems sensible to drop support now 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taylor-Mudd-9fin Taylor-Mudd-9fin Taylor-Mudd-9fin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GeorgeVince @Taylor-Mudd-9fin