URL encode the original image

[dannymidnight]

This fix addresses #13

Without url encoding thumbor will treat the generated url as malformed.

eg.
This is invalid:
http://thumbor.example.com/{hash}=/fit-in/320x240/http://example.com/llamas.jpg

This is valid:
http://thumbor.example.com/{hash}=/fit-in/320x240/http%3A%2F%2Fexample.com%2Fllamas.jpg'

@harto @lwc

[harto]

@dannymidnight we've gone back and forth on the URL-escaping. It depends on the version of Thumbor you use.

Are you absolutely sure the given example is invalid? In my experience, only certain URL characters need encoding. E.g. ~. See #10.

[dannymidnight]

haha oh man.. I wasn't aware of that discussion.

[harto]

Yep, it's confusing. Basically:

• Our current Thumbor server version needs ~ to be URL-escaped.
• The latest Thumbor server version handles ~ without URL-escaping.

So, your options are either:

• escape ~ in the original URL
• upgrade to a more recent Thumbor server version.

Related: thumbor/thumbor@1693d68

[dannymidnight]

Does preventing double encoding by urlencode(urldecode($original)) solve the issue for everyone?

[harto]

I think urlencode(urldecode($original)) is equivalent to urlencode($original)...

[pda]

Not exactly; each encode or decode adds or removes a layer of encoding.
And decoding is destructive — information about mixed encoding e.g. "one+two three%20four" is lost.

[dannymidnight]

Aight closing this and rolling with own urlencode within app.

[harto]

👍
Happy to help if you need it @dannymidnight