-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(lint): lint and test helm chart #103
Conversation
WalkthroughThe changes include updating the GitHub workflow triggers, adding a new workflow for linting and testing charts, refining maintainers' details in the Chart.yaml, improving formatting in values.yaml, and modifying the helmfile.yaml to specify the chart path. Changes
Poem
Tip Early access features: enabledWe are currently testing the following features in early access:
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/lint-test.yaml (1 hunks)
Additional comments not posted (7)
.github/workflows/lint-test.yaml (7)
1-7
: LGTM!The workflow is correctly triggered on pull requests and defines a job that runs on
ubuntu-latest
.
8-13
: LGTM!The
Checkout
step uses theactions/checkout@v3
action and correctly fetches the code with full history.
14-18
: LGTM!The
Set up Helm
step uses theazure/[email protected]
action to set up Helm versionv3.14.4
.
19-23
: LGTM!The
Set up Python
step uses theactions/setup-python@v5
action to set up the latest release of Python 3.x.
24-26
: LGTM!The
Set up chart-testing
step uses thehelm/[email protected]
action.
35-37
: LGTM!The
Run chart-testing (lint)
step runs thect lint
command if changes are detected.
39-45
: LGTM!The
Create kind cluster
step uses thehelm/[email protected]
action, and theRun chart-testing (install)
step runs thect install
command if changes are detected.
73d1289
to
3495724
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/lint-test.yaml (1 hunks)
- values.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- values.yaml
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/lint-test.yaml
9dca962
to
e7bbf55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
Chart.lock
is excluded by!**/*.lock
charts/n8n/Chart.lock
is excluded by!**/*.lock
Files selected for processing (4)
- .github/workflows/conventional-commits-check.yaml (1 hunks)
- .github/workflows/lint-test.yaml (1 hunks)
- charts/n8n/values.yaml (10 hunks)
- helmfile.yaml (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/conventional-commits-check.yaml
- helmfile.yaml
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/lint-test.yaml
Additional context used
GitHub Check: lint-test
charts/n8n/values.yaml
[failure] 4-4:
4:19 [comments] too few spaces before comment
[failure] 9-9:
9:23 [comments] too few spaces before comment
[failure] 10-10:
10:27 [comments] too few spaces before comment
[failure] 14-14:
14:9 [comments] too few spaces before comment
[failure] 120-120:
120:18 [comments] too few spaces before comment
Additional comments not posted (13)
charts/n8n/values.yaml (13)
69-69
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# port: +# port:Likely invalid or redundant comment.
204-204
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# lifecycle: +# lifecycle:Likely invalid or redundant comment.
55-55
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# executions: +# executions:Likely invalid or redundant comment.
67-67
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# path: +# path:Likely invalid or redundant comment.
70-70
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# listen_address: +# listen_address:Likely invalid or redundant comment.
65-65
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# generic: +# generic:Likely invalid or redundant comment.
90-90
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# endpoints: +# endpoints:Likely invalid or redundant comment.
73-73
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# ssl_cert: +# ssl_cert:Likely invalid or redundant comment.
72-72
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# ssl_key: +# ssl_key:Likely invalid or redundant comment.
95-95
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# externalHookFiles: +# externalHookFiles:Likely invalid or redundant comment.
50-50
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# credentials: +# credentials:Likely invalid or redundant comment.
71-71
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# protocol: +# protocol:Likely invalid or redundant comment.
29-29
: Adjust comment formatting.Ensure consistent spacing before comments for better readability.
-# database: +# database:Likely invalid or redundant comment.
5f95c9b
to
4e87c01
Compare
4e87c01
to
2e3900c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
Chart.lock
is excluded by!**/*.lock
charts/n8n/Chart.lock
is excluded by!**/*.lock
Files selected for processing (5)
- .github/workflows/conventional-commits-check.yaml (1 hunks)
- .github/workflows/lint-test.yaml (1 hunks)
- charts/n8n/Chart.yaml (1 hunks)
- charts/n8n/values.yaml (11 hunks)
- helmfile.yaml (1 hunks)
Files skipped from review due to trivial changes (1)
- charts/n8n/Chart.yaml
Files skipped from review as they are similar to previous changes (4)
- .github/workflows/conventional-commits-check.yaml
- .github/workflows/lint-test.yaml
- charts/n8n/values.yaml
- helmfile.yaml
Cool, thank you very much |
I'll take a look at it |
🌟 This PR introduces a new GitHub Actions workflow for linting and testing Helm charts upon every pull request. It ensures all charts meet our quality standards before they can be merged into the main branch.
🛠 Details:
ubuntu-latest
for running the jobs.🎯 Workflow Triggers:
⚙️ Additional Configurations:
👀 Reviewers:
🔍 Please review the setup and the steps included in the workflow. Let's ensure our Helm charts are up to the standards and ready for deployment without issues.
🔄 Impact:
💪 This action will enhance our CI/CD pipeline by automating the testing process, catching potential issues early in the development cycle.
Summary by CodeRabbit
New Features
Chores
values.yaml
.helmfile.yaml
.Style