Merge pull request #82 from 87kangsw/hotfix/trending-repo

[Release] 2.1.6

.gitignore

@@ -166,4 +166,6 @@ playground.xcworkspace
 GoogleService-Info.plist
 GitHub-Info.plist
 
+*.p8
+
 # End of https://www.gitignore.io/api/xcode,swift,carthage,fastlane,cocoapods,objective-c

GitTime/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json

@@ -1,153 +1,9 @@
 {
   "images" : [
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "2x",
-      "size" : "20x20"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "3x",
-      "size" : "20x20"
-    },
-    {
-      "filename" : "icon-small.png",
-      "idiom" : "iphone",
-      "scale" : "1x",
-      "size" : "29x29"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "2x",
-      "size" : "29x29"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "3x",
-      "size" : "29x29"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "2x",
-      "size" : "40x40"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "3x",
-      "size" : "40x40"
-    },
-    {
-      "filename" : "icon.png",
-      "idiom" : "iphone",
-      "scale" : "1x",
-      "size" : "57x57"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "2x",
-      "size" : "57x57"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "2x",
-      "size" : "60x60"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "iphone",
-      "scale" : "3x",
-      "size" : "60x60"
-    },
-    {
-      "filename" : "notification-icon~ipad.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "20x20"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "20x20"
-    },
-    {
-      "filename" : "icon-small.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "29x29"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "29x29"
-    },
-    {
-      "filename" : "icon-40.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "40x40"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "40x40"
-    },
-    {
-      "filename" : "icon-small-50.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "50x50"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "50x50"
-    },
-    {
-      "filename" : "icon-72.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "72x72"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "72x72"
-    },
-    {
-      "filename" : "icon-76.png",
-      "idiom" : "ipad",
-      "scale" : "1x",
-      "size" : "76x76"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "76x76"
-    },
-    {
-      "filename" : "[email protected]",
-      "idiom" : "ipad",
-      "scale" : "2x",
-      "size" : "83.5x83.5"
-    },
     {
       "filename" : "ios-marketing.png",
-      "idiom" : "ios-marketing",
-      "scale" : "1x",
+      "idiom" : "universal",
+      "platform" : "ios",
       "size" : "1024x1024"
     }
   ],

GitTime/Sources/ViewControllers/Trend/TrendViewReactor.swift

@@ -295,7 +295,7 @@ final class TrendViewReactor: Reactor {
 													 contributors: [])
 
                 // Repository Info
-				let repositoryInfo = item.xpath(".//h1[@class='h3 lh-condensed']/a")
+				let repositoryInfo = item.xpath(".//h2[@class='h3 lh-condensed']/a")
                 let description = item.xpath(".//p[@class='col-9 color-fg-muted my-1 pr-4']")
                 let languageColor = item.xpath(".//span[@class='d-inline-block ml-0 mr-3']/span[1]")
                 let language = item.xpath(".//span[@class='d-inline-block ml-0 mr-3']/span[2]")

GitTime/Supporting Files/Info.plist

@@ -85,7 +85,7 @@
 	<key>CFBundlePackageType</key>
 	<string>APPL</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.1.5</string>
+	<string>2.1.6</string>
 	<key>CFBundleURLTypes</key>
 	<array>
 		<dict>
@@ -100,7 +100,7 @@
 		</dict>
 	</array>
 	<key>CFBundleVersion</key>
-	<string>4</string>
+	<string>6</string>
 	<key>ITSAppUsesNonExemptEncryption</key>
 	<false/>
 	<key>LSApplicationQueriesSchemes</key>

Makefile

@@ -10,4 +10,7 @@ dev-upload:
 	fastlane ios develop firebase_upload:true groups:iOS slack_notify:true
 
 appstore:
-	fastlane ios release
+	fastlane ios release
+
+certificates:
+	fastlane ios certificates	

Podfile

@@ -79,6 +79,7 @@ post_install do |installer|
     installer.pods_project.targets.each do |target|
         target.build_configurations.each do |config|
         config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
+        config.build_settings['CODE_SIGNING_ALLOWED'] = 'NO'
       end
     end
 end

Podfile.lock

@@ -330,6 +330,6 @@ SPEC CHECKSUMS:
   URLNavigator: 2593c0e2d293732ec5c44503cf54dceba1a68085
   WeakMapTable: 05c694ce8439a7a9ebabb56187287a63c57673d6
 
-PODFILE CHECKSUM: 889e35fd688c78c4e6f036a683a2aed3bbd554c6
+PODFILE CHECKSUM: 6c50a4fed57d9b71f57165f5b813b2a632ecc271
 
 COCOAPODS: 1.11.3

fastlane/Fastfile

@@ -178,7 +178,31 @@ platform :ios do
   lane :release do
     sync_code_signing(type: "appstore")
     build_app(scheme: "GitTime")
-    upload_to_app_store(force: true)
+
+    api_key = app_store_connect_api_key(
+      key_id: ENV['CONNECT_API_KEY_ID'],
+      issuer_id: ENV['CONNECT_API_ISSUER_ID'],
+      key_filepath: ENV['CONNECT_API_KEY_FILE_PATH'],
+      duration: 1200, # optional (maximum 1200)
+      in_house: false # optional but may be required if using match/sigh
+    )
+
+    upload_to_app_store(
+      force: true,
+      api_key: api_key,
+      precheck_include_in_app_purchases: false
+    )
+  end
+
+  lane :certificates do
+    match(
+      type: "development",
+      app_identifier: ENV['APPLE_APP_IDENTIFIER']
+    )
+    match(
+      type: "appstore",
+      app_identifier: ENV['APPLE_APP_IDENTIFIER']
+    )
   end
 
 

fastlane/README.md

@@ -1,49 +1,72 @@
 fastlane documentation
-================
+----
+
 # Installation
 
 Make sure you have the latest version of the Xcode command line tools installed:
 
-```
+```sh
 xcode-select --install
 ```
 
-Install _fastlane_ using
-```
-[sudo] gem install fastlane -NV
-```
-or alternatively using `brew install fastlane`
+For _fastlane_ installation instructions, see [Installing _fastlane_](https://docs.fastlane.tools/#installing-fastlane)
 
 # Available Actions
+
 ## iOS
+
 ### ios develop
+
+```sh
+[bundle exec] fastlane ios develop
 ```
-fastlane ios develop
-```
+
 Beta Deployment to TestFlight
+
 ### ios firebase_upload
+
+```sh
+[bundle exec] fastlane ios firebase_upload
 ```
-fastlane ios firebase_upload
-```
+
+
 
 ### ios message_to_slack
+
+```sh
+[bundle exec] fastlane ios message_to_slack
 ```
-fastlane ios message_to_slack
-```
+
+
 
 ### ios new_member
+
+```sh
+[bundle exec] fastlane ios new_member
 ```
-fastlane ios new_member
-```
+
+
 
 ### ios release
+
+```sh
+[bundle exec] fastlane ios release
 ```
-fastlane ios release
+
+
+
+### ios certificates
+
+```sh
+[bundle exec] fastlane ios certificates
 ```
 
 
+
 ----
 
 This README.md is auto-generated and will be re-generated every time [_fastlane_](https://fastlane.tools) is run.
-More information about fastlane can be found on [fastlane.tools](https://fastlane.tools).
-The documentation of fastlane can be found on [docs.fastlane.tools](https://docs.fastlane.tools).
+
+More information about _fastlane_ can be found on [fastlane.tools](https://fastlane.tools).
+
+The documentation of _fastlane_ can be found on [docs.fastlane.tools](https://docs.fastlane.tools).