Ameba: Handle Naming/BlockParameterName
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI fails as Ameba runs on 1.6.1 and the rule was added in 1.6.0: https://github.com/crystal-ameba/ameba/releases/tag/v1.6.0
|
Ok, now new problems pop up as CI got further, but I think we should adress in separate PRs. |
oskgu360
approved these changes
Aug 26, 2024
|
Haha! Nice thinking there sir |
|
I think the fedora-39 build is stuck somehow, will just merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
CI fails as Ameba runs on 1.6.1 and the rule was added in 1.6.0:
https://github.com/crystal-ameba/ameba/releases/tag/v1.6.0
WHAT is this pull request doing?
Taking care of
Naming/BlockParameterNameoffenses. Decided to not change thepasparseris already taken in scope andoption_parserjust felt worse than the disabling (disable also affects less lines).HOW can this pull request be tested?
Specs