Fix building Dockerfile #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `libssl1.1` package does not exist in latest Alpine. `84codes/crystal:latest-alpine` builds using ssl3 and pcre2 since 84codes/crystal-container-images@7caa059 and 84codes/crystal-container-images@46aa4ea respectively. Also fix the warning: `- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)`
oskgu360
reviewed
Aug 29, 2024
oskgu360
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The
libssl1.1package does not exist in latest Alpine.84codes/crystal:latest-alpinebuilds using ssl3 and pcre2 since 84codes/crystal-container-images@7caa059 and 84codes/crystal-container-images@46aa4ea respectively.WHAT is this pull request doing?
Using
libssl3andpcre2instead oflibssl1.1andpcre.Also fixes the warning:
- FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 1)HOW can this pull request be tested?
docker build .