Skip to content

Fix template caching #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2017
Merged

Fix template caching #204

merged 3 commits into from
May 20, 2017

Conversation

leonard-thieu
Copy link
Contributor

@leonard-thieu leonard-thieu commented May 19, 2017 •
edited
Loading

Fixes #168

@45kb
Copy link
Member

45kb commented May 20, 2017 •
edited
Loading

Hi @leonard-thieu this is great!
Atm it is not 100% valid due to:

  • By default cache should be FALSE and not TRUE
  • Please do not commit dist/ folder

Can you make such changes so we can marge it?

thanks alot

@45kb 45kb merged commit 6fb45a3 into 720kb:master May 20, 2017
@45kb
Copy link
Member

45kb commented May 20, 2017

awesome, well done @leonard-thieu going to merge and release.

@leonard-thieu leonard-thieu deleted the template-cache branch May 20, 2017 14:43
45kb added a commit that referenced this pull request May 20, 2017
@45kb
fix for template-url-cache thanks to @leonard-thieu #204
5e7cc33
@45kb
Copy link
Member

45kb commented May 20, 2017

shipped with new v1.1.12 https://github.com/720kb/angular-tooltips/releases/tag/1.1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leonard-thieu @45kb