-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added code for robot to rotate precise angle and drive forward precis… #5
Open
jamest11235
wants to merge
7
commits into
main
Choose a base branch
from
autonomousDrive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chondl
requested changes
Apr 7, 2022
6238_prototype/src/main/java/frc/robot/subsystems/DriveSubsystem.java
Outdated
Show resolved
Hide resolved
private final double kCountsPerRev = 2048; | ||
private final double kGearRatio = 20; | ||
private final double kWheelRadiusInches = 2; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test this code by using driving the robot manually and measuring the distance it goes.
|
||
SmartDashboardParam kPSlider = new SmartDashboardParam("kPAutonomousDrive"); | ||
SmartDashboardParam kISlider = new SmartDashboardParam("kIAutonomousDrive"); | ||
SmartDashboardParam kDSlider = new SmartDashboardParam("kDAutonomousDrive"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need default values.
6238_prototype/src/main/java/frc/robot/commands/RotateCommand.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e distance