Resolve invitation error when user dose not exists any more #8027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phgross
requested changes
Aug 28, 2024
Abdu-moustafa
force-pushed
the
amo/TI-1036/fix/invitations-attribute_error_non_exists_inviter
branch
from
9a820eb
to
47e99d8
Compare
Moved the logic to the |
Abdu-moustafa
force-pushed
the
amo/TI-1036/fix/invitations-attribute_error_non_exists_inviter
branch
4 times, most recently
from
1784aca
to
7db16e6
Compare
phgross
requested changes
Sep 2, 2024
| # Add the invitation to the storage | ||
| self.storage._write_invitations[invitation_id] = entry | ||
|
|
||
| # Resolve the inviter from the invitation |
There was a problem hiding this comment.
This test does not actually check whether the problem still exists or not. Instead of manually fetching the inviter and create the actor from it, you should call the my-invitations view with the test user.
Abdu-moustafa
force-pushed
the
amo/TI-1036/fix/invitations-attribute_error_non_exists_inviter
branch
from
7db16e6
to
3bb6cee
Compare
lukasgraf
approved these changes
Sep 4, 2024
Abdu-moustafa
force-pushed
the
amo/TI-1036/fix/invitations-attribute_error_non_exists_inviter
branch
from
3bb6cee
to
d24147f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a recurring AttributeError encountered by users in Teamraum when handling invitations. The error was traced to an issue where a non-existent inviter was being referenced, leading to a failure in the invitation process.
For TI-1036
Before:
After:
Checklist
Everything has to be done/checked. Checked but not present means the author deemed it unnecessary.