Skip to content

Conversation

@D8H
Copy link
Collaborator

@D8H D8H commented Dec 9, 2025

@D8H D8H marked this pull request as ready for review December 10, 2025 15:44
@D8H D8H requested a review from 4ian as a code owner December 10, 2025 15:44
@4ian
Copy link
Owner

4ian commented Dec 10, 2025

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@4ian
Copy link
Owner

4ian commented Dec 10, 2025

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

decorators: [paperDecorator],
};

export const Sprite2d = () => (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these new stories 👍

@4ian
Copy link
Owner

4ian commented Dec 11, 2025

With the 3D editor, it's really cool :)

Bugs I've found:

  • If I click to add a 3D effect,

    image

    I get a 2D one:
    image

  • I can't change the type of a 3D effect, is that normal?
    image

  • I wonder if we should put a flag on the first row and the "Background color" row of the layers, so that it can't be selected and when it's hovered there is no background color change. Something like "selectable: false"

  • When I click on Rename, it opens the properties instead of doing what the shortcut is properly doing:
    image

The effects having a lot of things that are small numbers makes me think we should probably add to our "units", or some metadata, a notion of: min/max "soft range" (a recommend range, that would be what you navigate in the editor when you drag a slider or use the arrow keys to go up/down in this range. BUT you can write anything as long as it's in the hard limits) and a min/max "hard limits" (can't go above/beyond).

@4ian 4ian merged commit c629ba9 into master Dec 12, 2025
5 of 6 checks passed
@4ian 4ian deleted the effects-in-property-panel branch December 12, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants