Skip to content

Conversation

sarahgonicholson
Copy link

@sarahgonicholson sarahgonicholson commented Aug 12, 2025

  • Update the config file submitr/config/custom_column_mappings.json to include properties for DSA as well as DuplexSeq ExternalQualityMetric items
  • Fix handling of empty properties in ExternalQualityMetric spreadsheets
  • Update the handling of CUSTOM_COLUMN_MAPPINGS_LOCAL to use the local version of custom_column_mappings in submitr (rather than in dcicutils/submitr) when set to True to help with testing

NOTE: This is a temporary fix to allow submission of DSA_ExternalQualityMetric submission spreadsheets with submitr. Ideally, we would like to have this functionality moved over to submitr and have the config information pulled from the portal with a query to search/?type=GenericQcConfig&tags=external_quality_metrics, with the first returned item in search being the most recent version of the config. This may require moving submitr/custom_excel.py over to submitr as well.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16912433301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.375%

Totals Coverage Status
Change from base Build 13998979386: 0.0%
Covered Lines: 11454
Relevant Lines: 15196

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants