Second DRS Fix #297
Open
Second DRS Fix #297
+73
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschroed
approved these changes
Jun 26, 2024
aschroed
reviewed
Jun 27, 2024
| if 'accession' not in self.schema['properties']: | ||
| return keys | ||
| keys.setdefault('accession', []).extend(properties.get('alternate_accessions', [])) | ||
| if properties.get('status') != 'replaced' and 'accession' in properties: |
There was a problem hiding this comment.
Is the and 'accession' in properties clause needed - if you get here won't it definitely be there even if only an empty list from the line above?
And will this not be problematic for 'replaced' files as now this file that has the old accession as an alternative_accession will have a unique key conflict with the replaced file which is still accessible and in the db?
aschroed
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drs_id