Minor button styling adjustments #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And migrate to using d-flex align-items-center to position it. N.B. icon line-height inherit helps with icon centering/alignment, also.
|
@alexkb0009 I have tested locally and looks good to me! My only concern is that facet title looks darker and larger. I think, |
Bianca-Morris
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
Tested this on local CGAP, and it looks good (would be good to double check on 4DN re: Utku's concerns above).
I will say, though, that if the goal of making the switch to buttons is to get tab-navigation working, there's still a lot of work to be done in the FacetList component (there are some issues with how the dropdowns behave atm). Anyway, this is a step in the right direction, for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes some things in FacetList to be literal buttons (+ styling updates for it), such as the 'view more' buttons and facets' titles for better accessibility (i.e. ability to use keyboard interaction ([shift+]tab/enter/space) w. it).
(No Effect) Adds 'fixed-height' class to some buttons which only have icon(s) as child (and no text); not used right now / may come back to later. On 4DN, there's a style rule in bootstrap_overrides.scss that sets >i:only-child to have line-height: inherit; this seems to work decently (but not perfectly; not used if 2+ icons in same button..) which could use some testing on CGAP-side.