-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get release by tag name #499
base: main
Are you sure you want to change the base?
Get release by tag name #499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new test is failing for me locally, do you have the same?
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
===========================================
- Coverage 90.37% 78.70% -11.67%
===========================================
Files 24 24
Lines 613 620 +7
Branches 3 1 -2
===========================================
- Hits 554 488 -66
- Misses 59 132 +73
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your time @georgeorfanidi !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing documentation for getTag
, also it might be better to split this PR in two:
- one for getTag
- another one for getReleaseByTagName
so that they're not squashed into one commit, wdyt?
No description provided.