Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get release by tag name #499

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

georgeorfanidi
Copy link
Contributor

No description provided.

Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test is failing for me locally, do you have the same?

docs/docs/repository.md Outdated Show resolved Hide resolved
docs/docs/repository.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #499 into master will decrease coverage by 11.66%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #499       +/-   ##
===========================================
- Coverage   90.37%   78.70%   -11.67%     
===========================================
  Files          24       24               
  Lines         613      620        +7     
  Branches        3        1        -2     
===========================================
- Hits          554      488       -66     
- Misses         59      132       +73     
Impacted Files Coverage Δ
...ala/github4s/interpreters/GitDataInterpreter.scala 100.00% <100.00%> (ø)
...ithub4s/interpreters/RepositoriesInterpreter.scala 96.15% <100.00%> (+0.20%) ⬆️
github4s/src/main/scala/github4s/Github.scala 0.00% <0.00%> (-100.00%) ⬇️
...ithub4s/src/main/scala/github4s/GithubConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
...4s/src/main/scala/github4s/http/Http4sSyntax.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/domain/PullRequest.scala 0.00% <0.00%> (-100.00%) ⬇️
...s/src/main/scala/github4s/modules/GithubAPIs.scala 0.00% <0.00%> (-100.00%) ⬇️
.../src/main/scala/github4s/http/RequestBuilder.scala 0.00% <0.00%> (-100.00%) ⬇️
...ub4s/src/main/scala/github4s/http/HttpClient.scala 17.39% <0.00%> (-69.57%) ⬇️
.../scala/github4s/interpreters/AuthInterpreter.scala 46.66% <0.00%> (-53.34%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99b256e...030faf5. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your time @georgeorfanidi !

@juanpedromoreno juanpedromoreno added the enhancement New feature or request label Jun 7, 2020
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're missing documentation for getTag, also it might be better to split this PR in two:

  • one for getTag
  • another one for getReleaseByTagName
    so that they're not squashed into one commit, wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants