Improvement expected #25
Open
+115
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,55 +35,56 @@ template <typename T, typename ErrorT = std::string> | |||
| class Expected | |||
| { | |||
| public: | |||
| constexpr Expected() = delete; | |||
| constexpr Expected() = default; | |||
There was a problem hiding this comment.
no, you cant to have default ctor
|
|
||
| Expected(const Expected&) = delete; | ||
| Expected& operator=(const Expected&) = delete; | ||
| Expected(const Expected& other) = default; |
| constexpr const T&& value() const&& noexcept; | ||
| constexpr T&& value() && noexcept; | ||
| constexpr const ErrorT& error() const& noexcept; | ||
| constexpr const T& value() const&; |
There was a problem hiding this comment.
Why did you remove noexcept?
| ErrorT m_error; | ||
| }; | ||
| bool m_isError = false; | ||
| std::variant<T, ErrorT> m_value; |
There was a problem hiding this comment.
Why not union? this is more efficient type here
| template <typename UnErrorT> | ||
| Expected(Unexpected<UnErrorT>&& unex) noexcept; | ||
| template <typename UnErrorT> | ||
| Expected(const Unexpected<UnErrorT>& unex) noexcept; | ||
|
|
||
| Expected(const Expected&) = delete; | ||
| Expected& operator=(const Expected&) = delete; | ||
| Expected(const Expected& other) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.