Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added cors #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added cors #13

wants to merge 1 commit into from

Conversation

jjauzion
Copy link

Feature

  • added cors: edit env variable to set the allowed origin ( see Readme)

staeter
staeter suggested changes Aug 21, 2022
View reviewed changes
Copy link

@staeter staeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit détail dans le readme mais sinon je l'ai testé et ça fonctionne niquel :)

README.md
@@ -41,6 +41,7 @@ IS_DEV_ENV=true
TOKEN_DURATION_HOURS=24
WS_ES_USERNAME=""
WS_ES_PWD=""
WS_CORS_ALLOWED_ORIGIN=http://localhost:3000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WS_CORS_ALLOWED_ORIGIN=http://localhost:3000
WS_CORS_ALLOWED_ORIGIN=http://localhost:1234

This is the default port where ws-frontend is served on localhost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staeter staeter staeter requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jjauzion @staeter