Closed
Conversation
* Refactored to use assert_raises TODO: - [ ] Fix the timeout error test
When fetching headers, we rescue any authentication error and set the headers as application/json https://github.com/3scale/zync/blob/464cd87fda2275468ad4a94d9fbb54cfe98df10e/app/adapters/generic_adapter.rb#L136 The test rescues some error that is never raised
mikz
reviewed
Jun 4, 2019
| @error | ||
| end | ||
|
|
||
| def error(object) |
Contributor
There was a problem hiding this comment.
Why not using a MiniTest::Mock ?
akostadinov
previously approved these changes
May 10, 2022
Contributor
akostadinov
left a comment
akostadinov
left a comment
There was a problem hiding this comment.
I think this is a reasonable approach that can be improved another time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #196 (comment)
When fetching headers, we rescue any authentication error and set the
headers as application/json
zync/app/adapters/generic_adapter.rb
Line 136 in 464cd87
The test rescues an error that is never raised