Kt standard table wip #1029
Draft
Kt standard table wip #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Moritz Vetter <[email protected]>
…dd isLoading to DateRange picker, hide optional suffix in filter fields, replace ::v-deep with :deep(), fix typo in docs
Kt standard table cherrypick
Kt standard table inline filters
…ts, fix date range translations, update docs page
…-props-table-slot add boolean props, add table slot, remove pageIndex and pageSize even…
| }, | ||
| { | ||
| display: { decimalPlaces: 2, type: 'numerical' }, | ||
| filterFn: (row, columnId, filterValue) => { |
There was a problem hiding this comment.
filterFn is exposed in the Column type. Right now its implementation is on the user side. Could be moved into the standard table hook at the expense of leaving less flexibility in terms of the implementation/logic for the filters/values in the table.
| /** | ||
| * https://github.com/TanStack/table/discussions/4670 | ||
| */ | ||
| const globalFilter = ref<KottiFieldText.Value>(' ') |
There was a problem hiding this comment.
Apparently Column filters aren't applied until the Global filter is applied. Maybe this was fixed on a more recent version of tanstack table
| columnFilters: z | ||
| .object({ | ||
| id: z.string(), | ||
| // Zod schema `z.unknown()` incorrectly infers the property as optional |
There was a problem hiding this comment.
Zod has issues with the unknown type
Isokaeder
force-pushed
the
new-kt-table
branch
2 times, most recently
from
75f64c5 to
f001691
Compare
Isokaeder
force-pushed
the
new-kt-table
branch
2 times, most recently
from
4ee2681 to
793133f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.