-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Django 4.2 support on the write_migration_files
method
#268
Conversation
Hello @David-Wobrock I'm not sure if you have seen this PR yet, but please take a look at this and let me know what you think. |
Hey @faradayyg Thanks for the PR and the ping. I'll try to take some time soon to give some love again to the linter :) |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
- Coverage 94.10% 93.97% -0.13%
==========================================
Files 81 81
Lines 2034 2041 +7
==========================================
+ Hits 1914 1918 +4
- Misses 120 123 +3
☔ View full report in Codecov by Sentry. |
Hey @faradayyg Thanks for the PR and interesting in the project! About the PRFirst, I'll need you to rebase the PR against On the idea of the PRThe addition of the optional So what should the linter in this situation? So let's add tests about the |
Thanks for the detailed response @David-Wobrock I'll take a look and fix the issues. I'll also try to make a decision on the |
…linter into django-4-2-support
One year later, I have not been able to get to this. I will be closing this PR. Thank you! |
Django 4.2 introduced a new optional argument to the
write_migration_files
method of theCommand
class.While the current implementation works, it makes sense to modify to code so that the function parameters match, depending on what Django version is installed.