Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the volumetric spec #71

Merged
merged 21 commits into from
Aug 5, 2024
Merged

Improvements to the volumetric spec #71

merged 21 commits into from
Aug 5, 2024

Conversation

3dJan
Copy link
Contributor

@3dJan 3dJan commented Jul 31, 2024

This pull request fixes several issues with the Volumetric Extension. It includes the following commits:

  • [volumetric.xsd] Removing the 'channel' attribute from CT_FunctionFromImage3D
  • Moving Levelset in its own chapter
  • Running Formatter.py to apply the template
  • Adding python script for applying namespace prefixes to XML snippets
  • Adding namespace prefixes to the XML snippets
  • [Formatter.py] Refactor variable name 'implict' to 'implicit'

@3dJan 3dJan requested a review from ewaldbrADSK July 31, 2024 13:09
@3dJan 3dJan requested a review from ewaldbr2 August 2, 2024 12:50
@3dJan
Copy link
Contributor Author

3dJan commented Aug 5, 2024

There don't seem to be any complaints

@3dJan 3dJan merged commit 6497051 into implicit Aug 5, 2024
1 check passed
@3dJan 3dJan deleted the 3djan/implicit_improvements branch August 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewaldbrADSK ewaldbrADSK Awaiting requested review from ewaldbrADSK

@ewaldbr2 ewaldbr2 Awaiting requested review from ewaldbr2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@3dJan