Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Golang examples #390

Merged
merged 20 commits into from
Jan 21, 2025
Merged

Introduce Golang examples #390

merged 20 commits into from
Jan 21, 2025

Conversation

vijaiaeroastro
Copy link
Collaborator

@vijaiaeroastro vijaiaeroastro commented Sep 1, 2024

This PR introduces 7 golang examples (same as Python examples)

  • 3mf_convert.go
  • add_triangle.go
  • beam_lattice.go
  • color_cube.go
  • create_components.go
  • create_cube.go
  • extract_info.go

It currently imports the lib3mf library from https://github.com/3MFConsortium/lib3mf.go
Once ACT is patched / a decision is made on patching the bindings in the repo, examples can be adapted to work with local binding files

This PR also tests the create_cube.go script in Windows, Linux and OSX as a part of the deploy stage.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.08%. Comparing base (5fe4bd3) to head (dc0fb05).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
- Coverage    66.30%   59.08%   -7.23%     
===========================================
  Files          400       64     -336     
  Lines        45639    23589   -22050     
===========================================
- Hits         30262    13937   -16325     
+ Misses       15377     9652    -5725     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vijaiaeroastro
Copy link
Collaborator Author

The only solution that worked was bumping the Golang binding version to 2.4.1. It seems that the Golang package server caches the version, making it immutable.

@gangatp gangatp merged commit c2fd5e6 into develop Jan 21, 2025
41 of 42 checks passed
@gangatp gangatp deleted the vijai/golang_examples branch January 21, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants