Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clients with capability to set the encryption key of a resource data group #274

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

feliperoos
Copy link
Contributor

Hi @martinweismann

This hopes to close Issue #273 by enabling clients to specify an array with the content encryption key when creating a resource data group. This is still a WIP, I'd like to get your feedbacks on it first. If you think this is a good move, I'll improve testing.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #274 (32f1339) into develop (431d803) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
- Coverage    72.84%   72.83%   -0.01%     
===========================================
  Files          418      418              
  Lines        23274    23280       +6     
===========================================
+ Hits         16954    16957       +3     
- Misses        6320     6323       +3     
Impacted Files Coverage Δ
Include/API/lib3mf_keystore.hpp 100.00% <ø> (ø)
Source/API/lib3mf_keystore.cpp 82.97% <66.66%> (-1.47%) ⬇️
Autogenerated/Source/lib3mf_interfacewrapper.cpp 65.80% <0.00%> (-0.01%) ⬇️
Autogenerated/Source/lib3mf_interfaces.hpp 100.00% <0.00%> (ø)
Autogenerated/Bindings/Cpp/lib3mf_implicit.hpp 94.99% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431d803...32f1339. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant