Week8 thread handler looper #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KkamSonLee
reviewed
Aug 13, 2022
| } | ||
| } | ||
|
|
||
| @SuppressLint("HandlerLeak") |
There was a problem hiding this comment.
저도 궁금해서 찾아봤는데 핸들러 클래스가 외부 클래스에 대한 참조를 유지하지 않도록 한다고 하네요! inner class를 사용하셨기 때문에 ide에서 해당 어노테이션 추가를 제안했나봅니다~ 추후 inner class -> nested class로 변경해보시는 것도 추천합니다 :)
Comment on lines
+6
to
+8
|
|
||
| </data> |
There was a problem hiding this comment.
해당 태그는 사용안하시는거면 지워도 될 것 같습니다~!
Comment on lines
+80
to
+94
| inner class BackgroundThread3 : Thread() { | ||
| override fun run() { | ||
| //implement Count | ||
| while (isAlive) { | ||
| val bundle = Bundle() | ||
| val msg = myHandler.obtainMessage() | ||
| count++ | ||
| bundle.putInt("count", count) | ||
| with(msg) { | ||
| data = bundle | ||
| SystemClock.sleep(1000) | ||
| myHandler.sendMessage(this) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
여러번 눌렀을 때 처리도 해주시면 좋을 것 같습니다~!!
Comment on lines
+44
to
+46
| binding.img.post { | ||
| binding.img.setImageBitmap(ConvertBitMap().StringToBitmap(it)) | ||
| } |
| package="com.lee989898.myapplication"> | ||
|
|
||
| <uses-permission android:name="android.permission.INTERNET" /> | ||
| <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" /> |
There was a problem hiding this comment.
이미지 url로 가져올때 사용하고 있습니다!!
There was a problem hiding this comment.
glide로 이미지를 로드하신다면 INTERNET 권한만 있어도 충분하지 않나요?!
youngjinc
reviewed
Aug 13, 2022
|
|
||
| private lateinit var binding: ActivityMainBinding | ||
| private lateinit var myHandler: Handler | ||
| var count = 0 |
There was a problem hiding this comment.
Suggested change
| var count = 0 | |
| private var count = 0 |
| } | ||
| } | ||
|
|
||
| @SuppressLint("HandlerLeak") |
There was a problem hiding this comment.
저도 궁금해서 찾아봤는데 핸들러 클래스가 외부 클래스에 대한 참조를 유지하지 않도록 한다고 하네요! inner class를 사용하셨기 때문에 ide에서 해당 어노테이션 추가를 제안했나봅니다~ 추후 inner class -> nested class로 변경해보시는 것도 추천합니다 :)
| // 다른 Thread에서 전달받은 Message 처리 | ||
| val getBundle = msg.data | ||
| val img = getBundle.getString("image") | ||
| img.let { |
murjune
reviewed
Aug 18, 2022
Comment on lines
+44
to
+46
| binding.img.post { | ||
| binding.img.setImageBitmap(ConvertBitMap().StringToBitmap(it)) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.