Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use io.CopyBuffer instead of io.ReadAll #79

Closed
wants to merge 6 commits into from
Closed

Use io.CopyBuffer instead of io.ReadAll #79

wants to merge 6 commits into from

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Jun 14, 2024

Only if there is a cache hit, but memory efficiency is improved.

@k1LoW k1LoW self-assigned this Jun 14, 2024

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW added the minor label Jun 14, 2024
@k1LoW k1LoW requested a review from pyama86 June 14, 2024 06:28

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (1439b7d) #79 (783ecd1) +/-
Coverage 61.2% 61.9% +0.7%
Code to Test Ratio 1:2.2 1:2.2 -0.0
Test Execution Time 40s 39s -1s
Details
  |                     | main (1439b7d) | #79 (783ecd1) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          61.2% |         61.9% | +0.7% |
  |   Files             |              7 |             8 |    +1 |
  |   Lines             |            446 |           454 |    +8 |
+ |   Covered           |            273 |           281 |    +8 |
- | Code to Test Ratio  |          1:2.2 |         1:2.2 |  -0.0 |
  |   Code              |            758 |           773 |   +15 |
  |   Test              |           1685 |          1685 |     0 |
+ | Test Execution Time |            40s |           39s |   -1s |

Code coverage of files in pull request scope (76.2% → 77.9%)

Files Coverage +/-
copybuf.go 80.0% +80.0%
rc.go 77.8% +1.6%

Reported by octocov

@k1LoW k1LoW closed this Jun 14, 2024
@k1LoW k1LoW deleted the use-copy branch June 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant