Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use recorder instead of httptest.ResponseRecorder. #78

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Jun 14, 2024

Simplify implementation.

@k1LoW k1LoW self-assigned this Jun 14, 2024
Copy link
Contributor

Code Metrics Report

main (8148a60) #78 (e215311) +/-
Coverage 60.8% 61.2% +0.4%
Code to Test Ratio 1:2.3 1:2.2 -0.1
Test Execution Time 43s 45s +2s
Details
  |                     | main (8148a60) | #78 (e215311) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          60.8% |         61.2% | +0.4% |
  |   Files             |              7 |             7 |     0 |
  |   Lines             |            441 |           446 |    +5 |
+ |   Covered           |            268 |           273 |    +5 |
- | Code to Test Ratio  |          1:2.3 |         1:2.2 |  -0.1 |
  |   Code              |            729 |           758 |   +29 |
  |   Test              |           1685 |          1685 |     0 |
- | Test Execution Time |            43s |           45s |   +2s |

Code coverage of files in pull request scope (75.0% → 76.2%)

Files Coverage +/-
rc.go 76.2% +1.2%

Reported by octocov

@k1LoW k1LoW requested a review from pyama86 June 14, 2024 05:30
Copy link

@pyama86 pyama86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so simple!!

@k1LoW k1LoW merged commit 74dcb46 into main Jun 14, 2024
3 checks passed
@k1LoW k1LoW deleted the remove-http-recorder branch June 14, 2024 06:05
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
@k1LoW k1LoW added the minor label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants