Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extended rules like proxy_cache_valid of NGINX #38

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Dec 19, 2023

SSIA.

@k1LoW k1LoW added enhancement New feature or request minor breaking-change labels Dec 19, 2023
@k1LoW k1LoW self-assigned this Dec 19, 2023
@k1LoW k1LoW added the rfc9111 label Dec 19, 2023

This comment has been minimized.

@k1LoW k1LoW marked this pull request as draft December 19, 2023 09:28

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW marked this pull request as ready for review December 20, 2023 03:21
Copy link
Contributor

Code Metrics Report

main (4ad3acb) #38 (582f7d8) +/-
Coverage 80.3% 80.9% +0.6%
Code to Test Ratio 1:2.0 1:2.0 +0.0
Test Execution Time 36s 32s -4s
Details
  |                     | main (4ad3acb) | #38 (582f7d8) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          80.3% |         80.9% | +0.6% |
  |   Files             |              4 |             4 |     0 |
  |   Lines             |            279 |           299 |   +20 |
+ |   Covered           |            224 |           242 |   +18 |
+ | Code to Test Ratio  |          1:2.0 |         1:2.0 |  +0.0 |
  |   Code              |            623 |           660 |   +37 |
+ |   Test              |           1249 |          1324 |   +75 |
+ | Test Execution Time |            36s |           32s |   -4s |

Code coverage of files in pull request scope (86.9% → 87.3%)

Files Coverage +/-
rfc9111/shared.go 87.3% +0.4%

Reported by octocov

@k1LoW k1LoW merged commit 45b3316 into main Dec 20, 2023
3 checks passed
@k1LoW k1LoW deleted the extended-rules branch December 20, 2023 03:27
@github-actions github-actions bot mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant