Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For SNI compatibility, also compare req.Host #29

Merged
merged 1 commit into from
Dec 15, 2023
Merged

For SNI compatibility, also compare req.Host #29

merged 1 commit into from
Dec 15, 2023

Conversation

k1LoW
Copy link
Member

@k1LoW k1LoW commented Dec 15, 2023

SSIA.

@k1LoW k1LoW added the bug Something isn't working label Dec 15, 2023
@k1LoW k1LoW self-assigned this Dec 15, 2023
Copy link
Contributor

Code Metrics Report

main (89d106b) #29 (6c60695) +/-
Coverage 83.2% 83.2% 0.0%
Code to Test Ratio 1:2.2 1:2.2 +0.0
Test Execution Time 34s 35s +1s
Details
  |                     | main (89d106b) | #29 (6c60695) | +/-  |
  |---------------------|----------------|---------------|------|
  | Coverage            |          83.2% |         83.2% | 0.0% |
  |   Files             |              4 |             4 |    0 |
  |   Lines             |            256 |           256 |    0 |
  |   Covered           |            213 |           213 |    0 |
+ | Code to Test Ratio  |          1:2.2 |         1:2.2 | +0.0 |
  |   Code              |            579 |           579 |    0 |
+ |   Test              |           1245 |          1248 |   +3 |
- | Test Execution Time |            34s |           35s |  +1s |

Code coverage of files in pull request scope (86.9% → 86.9%)

Files Coverage +/-
rfc9111/shared.go 86.9% 0.0%

Reported by octocov

@k1LoW k1LoW merged commit 664d17b into main Dec 15, 2023
3 checks passed
@k1LoW k1LoW deleted the fix-url-match branch December 15, 2023 04:36
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant