Skip to content

Commit

Permalink
deployer: rename flag to --skip-refresh
Browse files Browse the repository at this point in the history
  • Loading branch information
AIDEA775 committed Jul 2, 2024
1 parent cd799dc commit 8839e90
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions deployer/commands/deployer.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,17 +117,17 @@ def deploy(
"--dry-run",
help="""When present, the `--dry-run` flag will be passed to the `helm upgrade` command.""",
),
skip_update: bool = typer.Option(
skip_refresh: bool = typer.Option(
False,
"--skip-update",
"--skip-refresh",
help="""When present, the helm charts and schemas will not be updated.""",
),
):
"""
Deploy one or more hubs in a given cluster
"""
validate_cluster_config(cluster_name)
validate_hub_config(cluster_name, hub_name, skip_update)
validate_hub_config(cluster_name, hub_name, skip_refresh)

config_file_path = find_absolute_path_to_cluster_file(cluster_name)
with open(config_file_path) as f:
Expand Down
8 changes: 4 additions & 4 deletions deployer/commands/validate/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ def _prepare_helm_charts_dependencies_and_schemas():

daskhub_dir = HELM_CHARTS_DIR.joinpath("daskhub")
# Not generating schema for daskhub, as it is dead
subprocess.check_call(["helm", "dep", "up", daskhub_dir])
subprocess.check_call(["helm", "dep", "up", daskhub_dir, "--skip-refresh"])

support_dir = HELM_CHARTS_DIR.joinpath("support")
_generate_values_schema_json(support_dir)
subprocess.check_call(["helm", "dep", "up", support_dir])
subprocess.check_call(["helm", "dep", "up", support_dir, "--skip-refresh"])


def get_list_of_hubs_to_operate_on(cluster_name, hub_name):
Expand Down Expand Up @@ -98,13 +98,13 @@ def cluster_config(
def hub_config(
cluster_name: str = typer.Argument(..., help="Name of cluster to operate on"),
hub_name: str = typer.Argument(None, help="Name of hub to operate on"),
skip_update: bool = typer.Argument(False, help="Skip the helm dep update"),
skip_refresh: bool = typer.Argument(False, help="Skip the helm dep update"),
):
"""
Validates the provided non-encrypted helm chart values files for each hub of
a specific cluster.
"""
if not skip_update:
if not skip_refresh:
_prepare_helm_charts_dependencies_and_schemas()

config_file_path = find_absolute_path_to_cluster_file(cluster_name)
Expand Down

0 comments on commit 8839e90

Please sign in to comment.