Support running multiple instances on same cluster #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this parameterization, all installations try to use the same hostPath paths and everything except 1 fails
GeorgianaElena
approved these changes
Jan 17, 2024
yuvipanda
force-pushed
the
multiple-binder
branch
from
9ec19e4 to
30b3e58
Compare
yuvipanda
force-pushed
the
multiple-binder
branch
from
7f541b4 to
7d6a025
Compare
for more information, see https://pre-commit.ci
|
Thanks @GeorgianaElena! I fixed the tests, will merge. |
yuvipanda
added a commit
that referenced
this pull request
Feb 8, 2024
Follow-up to #77 (which made wrong assumptions about HELM_DEPLOYMENT_NAME).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this parameterization, all installations try to use the same hostPath paths and everything except 1 fails