Add SoCalGas #7728
Merged
Add SoCalGas #7728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 28, 2023 12:08
Added json file for the Utility company SoCalGas Added documentation and 2fa types Added PNG logo image
Updated the json file to overwrite the default SVG format to the IMG format
Carlgo11
requested changes
Aug 28, 2023
entries/s/socalgas.com.json
Outdated
Comment on lines
3
to
8
| "domain": "socalgas.com", | ||
| "img": "site.com.png", | ||
| "tfa": ["sms", "totp"], | ||
| "documentation": "https://www.socalgas.com/help-center/2-factor-authentication", | ||
| "regions": ["us"], | ||
| "categories": ["utilities"] |
There was a problem hiding this comment.
Thanks for the pull request @johntheholman.
Could you please use the code style that the rest of the JSON files use? Where { and [ are followed by new lines and ] } are prefixed by new lines.
There was a problem hiding this comment.
I will update this. Not sure why the config is not working. Looking into that.
Added new lines per formatting guidance Added SVG logo Deleted PNG logo
Carlgo11
approved these changes
Aug 28, 2023
|
Thanks @Carlgo11 for such a quick turnaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added json file for the Utility company SoCalGas
Added documentation and 2fa types
Added PNG logo image