Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local.cfg #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

powerpbx
Copy link
Contributor

Add secondary and tertiary amqp as defined in default.cfg.

Also, I think there is a typo on your kamailio docs at http://www.kamailio.org/docs/modules/4.4.x/modules/kazoo.html

4.1.6. amqp_connection(str)

The connection url to rabbitmq. can be set multiple times for failover.

Example 1.7. Set amqp_connection parameter

...
modparam("kazoo", "amqp_connection", "amqp://guest:guest@localhost:5672")
modparam("kazoo", "amqp_connection", "kazoo://guest:guest@otherhost:5672")
...

Shouldn't the second modparam say:
"amqp://guest:guest@otherhost:5672"

Add secondary and tertiary amqp as defined in default.cfg
@lazedo
Copy link
Contributor

lazedo commented Feb 25, 2017

@powerpbx Hi, what is the intent of this pull request ?
the comment about the typo is wrong, you can either specify kazoo or amqp as the protocol part of the uri.

Corrected config.
@powerpbx
Copy link
Contributor Author

The intent is to document a feature that appears to be undocumented otherwise.

@@ -41,6 +41,18 @@
## in the zone that this server will service.
#!substdef "!MY_AMQP_URL!kazoo://guest:[email protected]:5672!g"

## CHANGE "kazoo://guest:[email protected]:5672" TO THE AMQP URL
## This should be the failover RabbitMQ server
## in the zone that this server will service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not supported


## CHANGE "kazoo://guest:[email protected]:5672" TO THE AMQP URL and uncomment
## This should be the secondary failover RabbitMQ server
## in the zone that this server will service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failover is not supported

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case, can you help me understand what this is, and how to document it?
/etc/kazoo/kamailio/default.cfg

amqp connections

modparam("kazoo", "amqp_connection", "MY_AMQP_URL")
#!ifdef MY_AMQP_SECONDARY_URL
modparam("kazoo", "amqp_connection", "MY_AMQP_SECONDARY_URL")
#!endif
#!ifdef MY_AMQP_TERTIARY_URL
modparam("kazoo", "amqp_connection", "MY_AMQP_TERTIARY_URL")
#!endif

@powerpbx
Copy link
Contributor Author

powerpbx commented Jun 13, 2017

From kamailio documentation.
http://www.kamailio.org/docs/modules/5.0.x/modules/kazoo.html

4.1.6. amqp_connection(str)
The connection url to rabbitmq. can be set multiple times for failover.

The documentation mentions failover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants