Update scraper test

21jake · Mar 12, 2023 · 3ff525f · 3ff525f
1 parent ebd5855
commit 3ff525f
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 11 deletions.
diff --git a/backend/src/utils/scraper.utils.ts b/backend/src/utils/scraper.utils.ts
@@ -106,6 +106,10 @@ export class HttpScraper {
 
   public getOverviewScrapedInfo() {
 
+    if (this.keyword.includes('throwerror')) {
+      throw new Error('This is a test error');
+    }
+
     if (!this.cheerioAPI) {
       throw new Error('No data scraped yet!');
     }

diff --git a/backend/test/file-upload.spec.ts b/backend/test/file-upload.spec.ts
@@ -20,7 +20,7 @@ import { ScraperService } from 'src/services/scraper.service';
 import { Repositories } from 'src/utils/enums/repositories.enum';
 import { generateRandomString } from 'src/utils/helpers';
 import request from 'supertest';
-import { Repository } from 'typeorm';
+import { In, Repository } from 'typeorm';
 // jest.useRealTimers();
 describe('File Upload', () => {
 
@@ -146,6 +146,9 @@ describe('File Upload', () => {
   };
 
   afterAll(async () => {
+    const instertedKeywords = getKws(samplePath_1);
+    await keywordRepository.delete({ name: In(instertedKeywords) });
+
     unlinkSync(path.join(appEnv.CSV_PATH, savedFileName));
     await app.close();
   });

diff --git a/backend/test/scraper.spec.ts b/backend/test/scraper.spec.ts
@@ -110,7 +110,7 @@ describe('Scraper', () => {
         createdDate: null,
       },
       {
-        name: generateRandomString(),
+        name: `${generateRandomString()}-throwerror`,
         batch: batch as any,
         fileName: null,
         success: null,
@@ -175,11 +175,16 @@ describe('Scraper', () => {
     const { keywords: keywordsAfterScraping } = await getTestBatch();
 
     keywordsAfterScraping.forEach((e) => {
-      expect(e.success).toBe(true);
-      expect(e.totalLinks).not.toBeNull();
-      expect(e.totalAds).not.toBeNull();
-      expect(e.searchTime).not.toBeNull();
-      expect(e.fileName).not.toBeNull();
+      if (e.success === true) {
+        expect(e.success).toBe(true);
+        expect(e.totalLinks).not.toBeNull();
+        expect(e.totalAds).not.toBeNull();
+        expect(e.searchTime).not.toBeNull();
+        expect(e.fileName).not.toBeNull();
+      } else {
+        expect(e.success).toBe(false);
+        expect(e.error).not.toBeNull();
+      }
     });
   }, 60_000);
 
@@ -196,10 +201,16 @@ describe('Scraper', () => {
     const successfulKwAfterRescraping = keywordsAfterRecraping.filter((e) => e.success);
 
     successfulKwAfterRescraping.forEach((e) => {
-      expect(e.success).toBe(true);
-      expect(e.totalLinks).not.toBeNull();
-      expect(e.totalAds).not.toBeNull();
-      expect(e.fileName).not.toBeNull();
+      if (e.success === true) {
+        expect(e.success).toBe(true);
+        expect(e.totalLinks).not.toBeNull();
+        expect(e.totalAds).not.toBeNull();
+        expect(e.searchTime).not.toBeNull();
+        expect(e.fileName).not.toBeNull();
+      } else {
+        expect(e.success).toBe(false);
+        expect(e.error).not.toBeNull();
+      }
     });
   }, 60_000);