[RTM] allow selection of which interest groups should be mandatory #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you think this is too much out of scope of this extension, any user could alternatively achieve something like that via hook, if implemented. public function modifyMailChimpForm(\Haste\Form\Form $objForm, \Oneup\Contao\MailChimpBundle\Module\ModuleSubscribe $objModule)
{
$objForm->getWidget('SALUTATION')->mandatory = true;
} |
|
I think we should go for a feature release. |
bytehead
reviewed
Jun 4, 2018
| @@ -66,9 +68,11 @@ | |||
| $GLOBALS['TL_DCA']['tl_module']['fields']['mailchimpMandatoryInterests'] = [ | |||
| 'label' => &$GLOBALS['TL_LANG']['tl_module']['mailchimpMandatoryInterests'], | |||
| 'inputType' => 'checkbox', | |||
| 'options_callback' => ['Oneup\Contao\MailChimpBundle\EventListener\DcaListener', 'onLoadInterests'], | |||
There was a problem hiding this comment.
Is it ok to use Oneup\Contao\MailChimpBundle\EventListener\DcaListener::class?
There was a problem hiding this comment.
Yeah, that's the way to go, didn't think of that.
There was a problem hiding this comment.
Ping @fritzmg who's gonna change? you or me?
There was a problem hiding this comment.
Me :) sorry, haven't had time yet
bytehead
changed the title
fritzmg
force-pushed
the
interest-mandatory-selection
branch
from
b951914 to
b67a959
Compare
bytehead
approved these changes
Jun 18, 2018
bytehead
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mailchimpMandatoryInterestsnow has anoptions_callbackthat loads the interest groups from the MailChimp list.'submitOnChange' => trueand'includeBlankOption' => truetoevalofmailchimpList.Careful: this changes the usage of the
mailchimpMandatoryInterestsfield. While previously it was a simple boolean, now it contains a blob of serialized groups that should be mandatory. Technically this would need to be released as a major version - though may be you can release it as a feature version, sincemailchimpMandatoryInterestswas only recently introduced...