Skip to content

add trunk check with all check-mode to code quality workflow #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

1a1a11a
Copy link
Owner

@1a1a11a 1a1a11a commented Jun 22, 2025

No description provided.

@1a1a11a 1a1a11a requested a review from Copilot June 22, 2025 15:30
@1a1a11a 1a1a11a requested a review from haochengxia as a code owner June 22, 2025 15:30
Copy link

trunk-io bot commented Jun 22, 2025

✨ Submitted to Merge by @1a1a11a. It will be added to the merge queue once all branch protection rules pass and there are no merge conflicts with the target branch. See more details here.

@1a1a11a 1a1a11a marked this pull request as draft June 22, 2025 15:30
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Trunk static analysis check to the existing code-quality workflow.

  • Introduces a Trunk Check step using trunk-io/trunk-action@v1
  • Configures the action to run in all check mode
Comments suppressed due to low confidence (1)

.github/workflows/code-quality.yml:19

  • The Trunk Action requires an API token for authentication. Please add a token input (e.g., from secrets.TRUNK_API_TOKEN) under the with block to ensure the step can authenticate successfully.
        uses: trunk-io/trunk-action@v1

@haochengxia
Copy link
Collaborator

Should we add concurrency check to avoid multiple actions for the same PR and save resources? Also set read-all to apply read-reconstruction for all job.

concurrency:
  group: ${{ github.head_ref || github.run_id }}
  cancel-in-progress: true

permissions: read-all

@1a1a11a
Copy link
Owner Author

1a1a11a commented Jun 22, 2025

Should we add concurrency check to avoid multiple actions for the same PR and save resources? Also set read-all to apply read-reconstruction for all job.

concurrency:
  group: ${{ github.head_ref || github.run_id }}
  cancel-in-progress: true

permissions: read-all

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants