CI Pipeline Runs example/example.py #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith parameters of created item. example.py reads vault id from env var. Call to run example.py added to pipeline
…or. Edited GitHub Secret names to match.
hculea
reviewed
Feb 3, 2025
| @@ -20,6 +20,7 @@ jobs: | |||
| matrix: | |||
There was a problem hiding this comment.
Leaving a comment here since GitHub UI doesn't allow me to do this above - since this is no longer running only integration tests, let's rename it to test-trusted instead of integration-test-trusted.
hculea
reviewed
Feb 3, 2025
Comment on lines
+115
to
+117
| - run: | | ||
| echo "Example file ran successfully!" | ||
|
|
There was a problem hiding this comment.
Let's remove this, as silence is golden.
hculea
reviewed
Feb 3, 2025
Comment on lines
+3
to
+4
| This folder contains a code snippet that demonstrates how to use the 1Password Python SDK to retrieve a secret from 1Password and export it as an environment variable. | ||
|
|
There was a problem hiding this comment.
This test example does much more, though - have we copy pasted this from somewhere?
hculea
reviewed
Feb 3, 2025
Comment on lines
+5
to
+15
| ## Prerequisites | ||
|
|
||
| 1. Clone the repository and follow the steps to [get started](https://github.com/1Password/onepassword-sdk-python/blob/main/README.md). | ||
| 2. Make sure to export a valid service account token. For example: | ||
| ```bash | ||
| export OP_SERVICE_ACCOUNT_TOKEN="<your token>" | ||
| ``` | ||
| 3. Make sure to export a valid vault uuid. For example: | ||
| ```bash | ||
| export OP_VAULT_ID="<your vault uuid>" | ||
| ``` |
There was a problem hiding this comment.
this doesn't actually explain how to run the example file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered logic in
example/example.pyto read the previously hardcodedvault_idfrom environment variables.Added
example/example.pyto the validation workflow, and readOP_SERVICE_ACCOUNT_TOKENandOP_VAULT_IDfrom GitHub secrets.Altered the example
client.secrets.resolveto resolve field from item created during theexample.pyitem CRUD.