Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate reference docs #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

Marton6
Copy link
Member

@Marton6 Marton6 commented Apr 3, 2024

This PR adds automatically generated reference docs.

The documentation is generated via the pydoc-markdown CLI.

How to test

  1. Install pydoc-markdown:
    pip install pydoc-markdown

  2. Run the generation script:
    ./scripts/generate_docs.sh

@Marton6 Marton6 requested review from AndyTitu and libutcher April 3, 2024 20:11
Copy link
Contributor

@libutcher libutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some questions! Looking at this, I think the comments also need another pass to make sure they're edited in a way that works with the docs. I can take that on separately, though.


v0.1.0

## Client Objects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to edit the doc generator so these headers are sentence cased? For example: "Client objects"

@@ -0,0 +1,35 @@
---
sidebar_label: client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this metadata is appearing on the front end as a table. Is there a way to avoid that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it.

class Client()
```

A client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look correct. I'm not sure where it's being source from.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sourced from a comment from client.py. It can be edited there, in place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange - I don't see "A client" in that file. Could you point me to it in case I'm missing something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants