Skip to content

Conversation

@edif2008
Copy link
Member

@edif2008 edif2008 commented Oct 30, 2025

📋 Summary

This PR enables the Go SDK to interact with the 1Password app on Windows.

🤔 Thought process

Using the golang.org/x/sys is common for this specific use case, so I relied on that package to make this. It's latest version updated our SDK to be built using Go 1.24, which is great given that this is a supported version right below the latest one (1.25).

🧪 How to test

  1. Run 1Password app on nightly on Windows and enable the internal feature flag for the SDKs for Desktop integrations.
  2. Checkout this branch.
  3. Update the account name in the example/desktop_app/main.go file.
  4. Export the OP_VAULT_ID and OP_GROUP_ID environment variables.
  5. Run the example program:
    go run example/desktop_app/main.go
    • It should prompt to authorize the SDK via the 1Password app
    • It should perform all the operations in the program successfully.

This shows that the file contains the implementation of interacting with the shared lib for UNIX systems (MacOS and Linux)
@edif2008 edif2008 marked this pull request as ready for review October 31, 2025 14:19
Extract common functionality present in both implementations for interacting with the shared lib
@edif2008 edif2008 force-pushed the eddy/add-shared-lib-core-windows branch from 6b713cc to 97c9531 Compare October 31, 2025 14:22
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edif2008 edif2008 merged commit 67faaef into sdks-for-desktop-integrations Nov 3, 2025
24 of 25 checks passed
@edif2008 edif2008 deleted the eddy/add-shared-lib-core-windows branch November 3, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants