fix: The functions in the library cannot be modified after being defined #1938
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return { | ||
| form: form > l.to ? l.to : form, | ||
| to: end_column && to_end_column < l.to ? to_end_column : l.to | ||
| } | ||
| } | ||
|
|
||
| const regexpLinter = linter(async (view) => { |
There was a problem hiding this comment.
The provided code snippet has some minor optimizations and corrections that can be suggested:
-
Variable Naming Consistency: The variable
to_end_columnis unnecessarily defined before use, which could be removed. -
Condition Simplification: The condition in the return statement of
getRangeFromLineAndColumncan be simplified using logical AND (&&) instead of multiple comparison checks.
Here's an optimized version of the function:
function getRangeFromLineAndColumn(state: any, line: number, column: number, end_column?: number): { form: number, to: number } {
const l = state.doc.line(line);
const form = l.from + column;
let rangeTo =
end_column !== undefined && end_column < l.to ?
l.from + end_column :
l.to;
return {
form: form > l.to ? l.to : form,
to: rangeTo
};
}These changes reduce redundancy and improve readability while maintaining correct functionality.
fix: The functions in the library cannot be modified after being defined