-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated creating a shadow root to use Shadow DOM v1 spec. This fixes … #719
base: master
Are you sure you want to change the base?
Conversation
…the broken hints functionality as of Chrome 80.0.3955.4.
Also fixed an indent issue on lines 40-42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, thanks!
@njohnson7 Any chance to merge and upload new version? |
Sorry I don't have write access... |
Looks good here. Thanks, @antonioyon! |
Thanks for the fix @antonioyon! Installed manually and works perfectly. Is there any indication that this will get merged? No updates to this project since November of 2017. Without this fix one of the main aspects of the extension is broken, rendering it pretty useless. |
I installed manually but it's not working for me. Using Chrome 80.0.3987.87 |
Fast check, have you installed from |
Can someone has permission get this fix merged and released? |
See #723 |
Hi @antonioyon - merged your branch into my fork here: https://github.com/dcchambers/vb4c Working on getting a fixed version uploaded to the Chrome web store now... |
…the broken hints functionality as of Chrome 80.0.3955.4.
Chrome 80.0.3955.4 and beyond follows v1 of the Shadow DOM spec. The
element.createShadowRoot()
function has been deprecated and replaced withelement.attachShadow({ mode: 'open' })
for an open shadow root.Fixes #716