Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated creating a shadow root to use Shadow DOM v1 spec. This fixes … #719

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antonioyon
Copy link

…the broken hints functionality as of Chrome 80.0.3955.4.

Chrome 80.0.3955.4 and beyond follows v1 of the Shadow DOM spec. The element.createShadowRoot() function has been deprecated and replaced with element.attachShadow({ mode: 'open' }) for an open shadow root.

Fixes #716

…the broken hints functionality as of Chrome 80.0.3955.4.
@antonioyon
Copy link
Author

Also fixed an indent issue on lines 40-42

Copy link

@njohnson7 njohnson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks!

@eyaleizenberg
Copy link

@njohnson7 Any chance to merge and upload new version?

@njohnson7
Copy link

@njohnson7 Any chance to merge and upload new version?

Sorry I don't have write access...

@ShawnConn
Copy link

Looks good here. Thanks, @antonioyon!

@dcchambers
Copy link

Thanks for the fix @antonioyon! Installed manually and works perfectly.

Is there any indication that this will get merged? No updates to this project since November of 2017. Without this fix one of the main aspects of the extension is broken, rendering it pretty useless.

@eyaleizenberg
Copy link

I installed manually but it's not working for me. Using Chrome 80.0.3987.87

@antoniobusrod
Copy link

@eyaleizenberg

I installed manually but it's not working for me. Using Chrome 80.0.3987.87

Fast check, have you installed from issue-716-fix-broken-hints branch?

@andrewpsy
Copy link

Can someone has permission get this fix merged and released?
Thanks.

@ShawnConn
Copy link

See #723

@dcchambers
Copy link

dcchambers commented Mar 10, 2020

Hi @antonioyon - merged your branch into my fork here: https://github.com/dcchambers/vb4c

Working on getting a fixed version uploaded to the Chrome web store now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chrome 80.0.3955.4] hints broken - Element.createShadowRoot deprecated
8 participants