consistent search behavior - '%s' format vs append #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following should result in the same search url, but they don't:
open DEFAULTENGINE needle
open? needle
open needle
If DEFAULTENGINE is configured as
let searchengine myengine = "http://my.engi.ne/search?q=%s"
let defaultengine = "myengine"
Then the 3 open commands result in:
http://my.engi.ne/search?q=needle # OK
http://my.engi.ne/search?q=%sneedle # ?
http://my.engi.ne/search?q=%sneedle # ?
This fix makes the behavior consistent regardless of whether or not the
search engine to use is explicit; from README.md -