-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for native TypeScript #5815
Conversation
**Why**: One of the other advantages / hopes with #5746 was a more direct path to incrementally adopting native TypeScript if we choose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM let's goooo
Required for production build
Simplify diff
I need to take a closer look at this logic, which was revised as part of #5746 (not yet deployed to production). Seems like it could already be problematic for identity-idp/app/javascript/packages/rails-i18n-webpack-plugin/extract-keys-webpack-plugin.js Lines 44 to 51 in 3945fb0
Thinking one of either:
|
Actually, it turns out this is fine, likely because it's the output having the
|
Why: One of the other hopes with #5746 was a more direct path to incrementally adopting native TypeScript if we choose. The proposed advantage here is improved syntax, Prettier integration, and clarity of inline code documentation in place of the JSDoc-based typings.