Update GitHub Pages workflow example #1704
Conversation
|
@bencampion is attempting to deploy a commit to the 11ty Team on Vercel. A member of the Team first needs to authorize it. |
| <ol> | ||
| <li>Go to your repository’s Settings on GitHub.</li> | ||
| <li>In the GitHub Pages section change:<ul><li>Source: <code>Deploy from a branch</code></li><li>Branch: <code>gh-pages/(root)</code></li></ul></li> | ||
| <li>In the GitHub Pages section change:<ul><li>Source: <code>GitHub Actions</code></li></ul></li> |
There was a problem hiding this comment.
Are you sure you want to deploy for every update of the main branch?
There was a problem hiding this comment.
It's only meant to be an example so I don't think the branch used here really matters that much. The build and deploy jobs are the important part. People can change when those jobs are ran to fit their requirements.
There was a problem hiding this comment.
I like this approach but this changes the what the tutorial was doing ( use a specific build-gh pages script and peaceiris/actions-gh-pages ) hence my remark.
Maybe you should rebase this branch since @zachleat merged a related PR to fix an issue.
#1771
I would support the update you propose because to me it look simpler.
bencampion
force-pushed
the
github-pages-workflow
branch
from
9191003 to
0f64ef9
Compare
2 participants
I've updated the GitHub Pages workflow example to use actions for the actual deployment and to set
--pathprefix.I've also change how the caching works as I don't think the previous example would have worked correctly for most use cases. You can't change the contents of an existing cache so if you keep on reusing the same cache key then you'll eventually end up with a saved
.cachefolder that only contains stale entries.I think it would be more useful to restore the cache saved from the last run so I've changed the cache action to use a key based on the current timestamp so it will always create a new cache on each run. This means there will never be a direct cache hit on subsequent runs, but I've also set
restore-keysso it will restore the last saved cache (from the same branch) on a miss.I'm quite new to GitHub actions so maybe there is a more elegant way to achieve this behaviour!